Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linker defaults for .NET 6 #5751

Closed
sbomer opened this issue Mar 16, 2021 · 0 comments · Fixed by #5781
Closed

Update linker defaults for .NET 6 #5751

sbomer opened this issue Mar 16, 2021 · 0 comments · Fixed by #5781
Assignees
@jonathanpeppers
Labels
Area: Linker Issues when linking assemblies.
Milestone
In Preview: 11.3 ...

Comments

@sbomer
Copy link
Member

sbomer commented Mar 16, 2021

In dotnet/sdk#16327, the .NET SDK is changing the linker defaults to TrimMode=link, with SuppressTrimAnalysisWarnings=false. Xamarin-android should consider doing the following when this change flows:
@sbomer sbomer added the needs-triage Issues that need to be assigned. label Mar 16, 2021
@jpobst jpobst assigned jonathanpeppers and unassigned jpobst Mar 16, 2021
@jpobst jpobst added Area: Linker Issues when linking assemblies. and removed needs-triage Issues that need to be assigned. labels Mar 16, 2021
@jpobst jpobst added this to the One .NET milestone Mar 16, 2021
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Mar 25, 2021
@jonathanpeppers
[One .NET] default $(SuppressTrimAnalysisWarnings) to true
94f7482 
Fixes: dotnet#5751

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
@jonathanpeppers jonathanpeppers mentioned this issue Mar 25, 2021
Merged
jonathanpeppers added a commit that referenced this issue Mar 26, 2021
@jonathanpeppers
[One .NET] default $(SuppressTrimAnalysisWarnings) to true (#5781)
3137b6d 
Fixes: #5751

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathanpeppers jonathanpeppers

Labels
Area: Linker Issues when linking assemblies.
Projects
None yet
Milestone
In Preview: 11.3 (d16-10)
Development

Successfully merging a pull request may close this issue.

[One .NET] default $(SuppressTrimAnalysisWarnings) to true jonathanpeppers/xamarin-android
4 participants
@jonpryor @jpobst @sbomer @jonathanpeppers