-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Allow users to specify modules for apk sets. #5327
Conversation
cb1eb37
to
e09ada7
Compare
050c4f0
to
34a281a
Compare
27e4f99
to
9125548
Compare
51e869d
to
b0a969c
Compare
b0a969c
to
0a162ea
Compare
0a162ea
to
db3bd6f
Compare
Some "public facing" documentation would be useful, not so much so that we can have something in For example, this approach involves using the |
@jonpryor currently this new |
…ets. Context dotnet#4810 When using app bundles users install the application from an `apkset`. At this time this only contains the base application. However we might in the future support dynamic features in some fashion. In this case developers should be able to pick which features they want installed. This commit adds an `AndroidInstallModules` ItemGroup which will allow developers to specify which modules to install. By default it will be empty. This means all modules which are to be installed on first install will be installed. So there is no change in the current behavior. This commit also adds support for passing additional arguments to `bundletool` via the new `$(AndroidBundleToolExtraArgs)` property.
@jonpryor I had added the docs for the ItemGroup here https://github.com/xamarin/xamarin-android/pull/5327/files#diff-db5645f8a1e864de401ac4a261afe73af36e10043135012bebc8cacfeb3820d0R149. There isn't much more to say since uses can't use this feature yet unless they build a module completely manually (and process is not not documented). |
Context #4810
When using app bundles users install the application from an
apkset
.At this time this only contains the base application. However we might
in the future support dynamic features in some fashion. In this case
developers should be able to pick which features they want installed.
This commit adds an
AndroidInstallModules
ItemGroup which will allowdevelopers to specify which modules to install. By default it will be
empty. This means all modules which are to be installed on first install
will be installed. So there is no change in the current behavior.
This commit also adds support for passing additional arguments to
bundle tool
via the newAndroidBundleToolExtraArgs
property.