From 26abe1badc06a58794c47a83aca2be996940719a Mon Sep 17 00:00:00 2001 From: Ankit Date: Thu, 17 May 2018 17:38:11 -0400 Subject: [PATCH] [tests] Fix tests that depend on tool output Lot of tests depend on comparing text in tool output. In xbuild, this was logged with `MessageImportance.Normal` but in msbuild the default is `MessageImportance.Low`. So, now the tool output doesn't show up in the normal verbosity log, causing the build to fail. Due to the number of tests depending on this, the default is changed to `diagnosticMSBuild = true`. A better way would probably (future) be to use a custom logger and get the output from the logging events. --- tests/common/mac/ProjectTestHelpers.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/common/mac/ProjectTestHelpers.cs b/tests/common/mac/ProjectTestHelpers.cs index cee161edb719..09c3dcd0989d 100644 --- a/tests/common/mac/ProjectTestHelpers.cs +++ b/tests/common/mac/ProjectTestHelpers.cs @@ -167,6 +167,7 @@ public class UnifiedTestConfig public UnifiedTestConfig (string tmpDir) { TmpDir = tmpDir; + DiagnosticMSBuild = true; } }