Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to immediately delete projects in Premium/Ultimate tiers #2008

Closed
heidiberry opened this issue Sep 7, 2024 · 1 comment · Fixed by #2010
Closed

Ability to immediately delete projects in Premium/Ultimate tiers #2008

heidiberry opened this issue Sep 7, 2024 · 1 comment · Fixed by #2010

Comments

@heidiberry
Copy link
Contributor

For the Premium and Ultimate tiers, by default projects are not deleted immediately on request. You can override this by passing two options to the API, full_path and permanently_remove: https://docs.gitlab.com/ee/api/projects.html#delete-project.

Prior to these fields being added to the API, there were no custom options used by the delete project endpoint. Therefore, the function for this has only two parameters: https://github.com/xanzy/go-gitlab/blob/main/projects.go#L1166.

How would you go about adding a DeleteProjectOptions parameter whilst maintaining backwards compatibility?

@svanharmelen
Copy link
Member

The GitLab API changes a lot so it's pretty hard to keep this package up-to-data without breaking some of the API's every now and then. However annoying it may be, I don't really see how else to fix these issue without creating a massive additional maintenance burden. So I'm good with adding an option struct argument to the delete project method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants