Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using normalize=False as default for all scores #203

Closed
nicrie opened this issue Aug 31, 2024 · 1 comment · Fixed by #216
Closed

Using normalize=False as default for all scores #203

nicrie opened this issue Aug 31, 2024 · 1 comment · Fixed by #216

Comments

@nicrie
Copy link
Contributor

nicrie commented Aug 31, 2024

With the upcoming major release, should we consider changing the default of the normalize parameter in the various (PC) scores from True to False? This would better align with the scikit-learn API, potentially reducing confusion for users familiar with that framework. Do you have strong opinions on this @slevang ?

@slevang
Copy link
Contributor

slevang commented Aug 31, 2024

That seems reasonable but no strong opinions from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants