Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XForm "mat" versus "matrix" properties should be renamed #494

Open
2 of 12 tasks
tsherif opened this issue Aug 1, 2016 · 1 comment
Open
2 of 12 tasks

XForm "mat" versus "matrix" properties should be renamed #494

tsherif opened this issue Aug 1, 2016 · 1 comment
Assignees
@xeolabs

Comments

@tsherif
Copy link
Collaborator

tsherif commented Aug 1, 2016 •
edited
Loading

Description of the problem

Xform nodes contain both mat and matrix properties. The difference is that mat contains the multiplied hierarchical transforms, whereas matrix contains the local transform of the node. This is unclear from the names (and led to this bug), so I'd suggest using more expressive names. Maybe localMatrix and globalMatrix?
...

SceneJS version
  • Dev
  • Master
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements
@xeolabs
Copy link
Owner

xeolabs commented Aug 1, 2016

Agreed - I'll make it "localMatrix" and "modelMatrix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeolabs xeolabs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xeolabs @tsherif