New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined index: xxxx #29

Open

janimattiellonen opened this issue Jun 8, 2014 · 1 comment

janimattiellonen commented Jun 8, 2014

A lot of configurations are currently assumed to be configured. If they are not, then a "Undefined index: xxx" warning is issued.

Maybe add an isset() call to mitigate these unnecessary warnings?
If these are required values then an exception could be thrown if a specific index is missing.

See Xi\Bundle\FilelibBundle\DependencyInjection\XiFilelibExtension::load()

Author

janimattiellonen commented Jun 8, 2014

Apparently this can be fixed also by using addDefaultsIfNotSet() in Xi\Bundle\FilelibBundle\DependencyInjection\Configuration class and provide sensible defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment