Interface inheritance is translated incorrectly

[marcoqu]

In cases of interface inheritance, the generated json schema joins the two definitions with allOf.
However, when the definitions have "additionalProperties": false the generated schema is incorrect.

A possible workaround, is having "additionalProperties": true for both the extended and the extending interface (but this would allow also for other properties).

Test case:

interface Example extends BaseExample {
    exampleProperty: string;
}

interface BaseExample {
    baseExampleProperty: number;
}

Error:

Property baseExampleProperty is not allowed.
Property exampleProperty is not allowed.

More about the issue:
json-schema-org/json-schema-spec#348
https://spacetelescope.github.io/understanding-json-schema/reference/combining.html

[mrix]

Hi @marcoqu. The solution provided by #35 should partly fix this bug. The only problem left is additionalProperties: false overriding for named definitions:

Accoriding to the specification:

Any members other than "$ref" in a JSON Reference object SHALL be ignored.

Possible solutions are still being discussed:

• Overriding annotation/usage keywords at point of use json-schema-org/json-schema-spec#98
• Flexible re-use: deferred keywords vs schema transforms json-schema-org/json-schema-spec#515

[marcoqu]

Hi @mrix, Thanks about this!
I see that in the huge Vega Lite pull request they also seem to have approached the same issue.
Is that pull request (or elements of it) going to get merged or have they become two different, incompatible projects?