Skip to content

Commit

Permalink
fix(build): do not break build on webpack warnings
Browse files Browse the repository at this point in the history
Breaking the webpack build on webpack warnings seems a little too
restrictive.
For example the performance hints are logged as warnings and therefore
break the build.

After this change the build will only exit with an error code of 1, if
the build contains errors, but not if the build only contains warnings.
  • Loading branch information
ZauberNerd committed Mar 27, 2018
1 parent 50cd728 commit 0c1518f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/build/commands/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ module.exports = function defineBuildCommand(args) {
);
}

if (error || stats.hasErrors() || stats.hasWarnings()) {
if (error || stats.hasErrors()) {
process.exit(1);
}
});
Expand Down

0 comments on commit 0c1518f

Please sign in to comment.