Skip to content

Latest commit

 

History

History
78 lines (63 loc) · 1.4 KB

formatting1.md

File metadata and controls

78 lines (63 loc) · 1.4 KB

函数调用者和被调用者应该靠近

Bad logo

	class PerformanceReview {
	  constructor(employee) {
	    this.employee = employee;
	  }
	
	  lookupPeers() {
	    return db.lookup(this.employee, "peers");
	  }
	
	  lookupManager() {
	    return db.lookup(this.employee, "manager");
	  }
	
	  getPeerReviews() {
	    const peers = this.lookupPeers();
	    // ...
	  }
	
	  perfReview() {
	    this.getPeerReviews();
	    this.getManagerReview();
	    this.getSelfReview();
	  }
	
	  getManagerReview() {
	    const manager = this.lookupManager();
	  }
	
	  getSelfReview() {
	    // ...
	  }
	}
	
	const review = new PerformanceReview(employee);
	review.perfReview();

Good logo

	class PerformanceReview {
	  constructor(employee) {
	    this.employee = employee;
	  }
	
	  perfReview() {
	    this.getPeerReviews();
	    this.getManagerReview();
	    this.getSelfReview();
	  }
	
	  getPeerReviews() {
	    const peers = this.lookupPeers();
	    // ...
	  }
	
	  lookupPeers() {
	    return db.lookup(this.employee, "peers");
	  }
	
	  getManagerReview() {
	    const manager = this.lookupManager();
	  }
	
	  lookupManager() {
	    return db.lookup(this.employee, "manager");
	  }
	
	  getSelfReview() {
	    // ...
	  }
	}
	
	const review = new PerformanceReview(employee);
	review.perfReview();