feat: implement WAL segments remover #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
wal-segment-remover
branch
from
6b51017
to
c2dae00
Compare
bsbds
force-pushed
the
wal-segment-remover
branch
from
c2dae00
to
359c2aa
Compare
|
Rebased on #705 |
bsbds
force-pushed
the
wal-segment-remover
branch
from
3854ff5
to
2eac564
Compare
Phoenix500526
previously approved these changes
Mar 27, 2024
bsbds
force-pushed
the
wal-segment-remover
branch
from
2eac564
to
a093667
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
wal-segment-remover
branch
from
a093667
to
d14c3c1
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
wal-segment-remover
branch
from
d14c3c1
to
d987b8c
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
wal-segment-remover
branch
from
d987b8c
to
2e06dc5
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
wal-segment-remover
branch
from
d714680
to
8817f47
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
wal-segment-remover
branch
from
8817f47
to
1ed0f97
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
wal-segment-remover
branch
2 times, most recently
from
cf46d54
to
54c90eb
Compare
Phoenix500526
previously approved these changes
Apr 30, 2024
|
@bsbds Your PR is in conflict and cannot be merged. |
bsbds
force-pushed
the
wal-segment-remover
branch
from
8b91ae0
to
17a8c17
Compare
Phoenix500526
approved these changes
May 11, 2024
rogercloud
reviewed
May 13, 2024
bsbds
force-pushed
the
wal-segment-remover
branch
from
17a8c17
to
57860a5
Compare
Phoenix500526
approved these changes
May 18, 2024
Phoenix500526
previously approved these changes
May 21, 2024
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
rogercloud
approved these changes
May 28, 2024
bsbds
force-pushed
the
wal-segment-remover
branch
from
c109919
to
26fdc28
Compare
Phoenix500526
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: #705
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement WAL segment remover, the segment remover is used to make sure a wal segment file is atomically removed.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)