feat: implement curp wal storage #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
curp-wal-storage
branch
2 times, most recently
from
71d1c79
to
25af141
Compare
bsbds
force-pushed
the
curp-wal-storage
branch
2 times, most recently
from
bd42b0f
to
0b5505d
Compare
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
curp-wal-storage
branch
from
25ca007
to
ea1b72d
Compare
|
@bsbds Your PR is in conflict and cannot be merged. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 75.55% 75.73% +0.17%
==========================================
Files 180 192 +12
Lines 26938 28121 +1183
Branches 26938 28121 +1183
==========================================
+ Hits 20353 21297 +944
- Misses 5366 5506 +140
- Partials 1219 1318 +99 ☔ View full report in Codecov by Sentry. |
Phoenix500526
force-pushed
the
curp-wal-storage
branch
from
1d1c293
to
d20163c
Compare
This was referenced Jun 16, 2024
Merged
Phoenix500526
requested changes
Jun 24, 2024
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> refactor: wal storage Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #740
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
This is part of the wal implementation, which implements the WAL storage type
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)