refactor: switch wal to sync implementation #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
wal-sync-impl
branch
from
13ba1bf
to
a7224fb
Compare
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase --autosquash |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
wal-sync-impl
branch
from
a7224fb
to
7432a34
Compare
bsbds
force-pushed
the
wal-sync-impl
branch
2 times, most recently
from
a3768a3
to
7060574
Compare
rogercloud
reviewed
Apr 30, 2024
bsbds
force-pushed
the
wal-sync-impl
branch
2 times, most recently
from
3fe0f18
to
dff9035
Compare
rogercloud
approved these changes
May 7, 2024
rogercloud
approved these changes
May 7, 2024
|
@Mergifyio rebase |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
…rror Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
wal-sync-impl
branch
from
dff9035
to
4eed780
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 75.55% 75.62% +0.06%
==========================================
Files 180 187 +7
Lines 26938 27441 +503
Branches 26938 27441 +503
==========================================
+ Hits 20353 20752 +399
- Misses 5366 5419 +53
- Partials 1219 1270 +51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Switch the curp WAL to synchronous implementation, as the current async version is slow in benchmarks.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)