Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Index #807

Merged
merged 1 commit into from
Jul 16, 2024
Merged

refactor: Index #807

merged 1 commit into from
Jul 16, 2024

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented May 9, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team May 9, 2024 08:10
Copy link

mergify bot commented May 9, 2024

@bsbds Convert your pr to draft since CI failed

@bsbds bsbds force-pushed the index-refactor branch 2 times, most recently from 6ba29f5 to ab2ab18 Compare May 11, 2024 02:42
@bsbds bsbds marked this pull request as ready for review May 11, 2024 02:42
@Phoenix500526
Copy link
Collaborator

@Mergifyio rebase

@xline-kv xline-kv deleted a comment from codecov bot May 20, 2024
Copy link

mergify bot commented May 20, 2024

rebase

✅ Branch has been successfully rebased

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 81.89189% with 67 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (e35b35a) to head (7b582d9).
Report is 147 commits behind head on master.

Files Patch % Lines
crates/xline/src/storage/index.rs 82.50% 59 Missing and 4 partials ⚠️
crates/xline/src/storage/kv_store.rs 57.14% 0 Missing and 3 partials ⚠️
crates/xline/src/server/command.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   75.55%   75.96%   +0.41%     
==========================================
  Files         180      189       +9     
  Lines       26938    28563    +1625     
  Branches    26938    28563    +1625     
==========================================
+ Hits        20353    21698    +1345     
- Misses       5366     5532     +166     
- Partials     1219     1333     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/xline/src/server/command.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 20, 2024 04:02
Copy link

mergify bot commented Jun 11, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft June 11, 2024 10:10
@mergify mergify bot added the CI:fail CI has failed label Jun 11, 2024
@mergify mergify bot marked this pull request as ready for review June 11, 2024 10:40
@mergify mergify bot removed the CI:fail CI has failed label Jun 11, 2024
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/index.rs Outdated Show resolved Hide resolved
@Phoenix500526
Copy link
Collaborator

Please squash these commits into one.

@mergify mergify bot requested a review from a team June 17, 2024 06:28
@bsbds bsbds force-pushed the index-refactor branch 2 times, most recently from 9678820 to 3d0329c Compare June 19, 2024 03:31
Copy link

mergify bot commented Jun 21, 2024

@bsbds Your PR is in conflict and cannot be merged.

Copy link

mergify bot commented Jun 21, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft June 21, 2024 02:48
@mergify mergify bot added the CI:fail CI has failed label Jun 21, 2024
@mergify mergify bot marked this pull request as ready for review June 21, 2024 03:09
@mergify mergify bot removed the CI:fail CI has failed label Jun 21, 2024
@bsbds bsbds added this to the v0.7.0 milestone Jul 1, 2024
Copy link

mergify bot commented Jul 2, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft July 2, 2024 02:41
@mergify mergify bot added the CI:fail CI has failed label Jul 2, 2024
@mergify mergify bot marked this pull request as ready for review July 5, 2024 03:06
@mergify mergify bot removed the CI:fail CI has failed label Jul 5, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash these commits into one.

@mergify mergify bot requested a review from a team July 16, 2024 01:54
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 merged commit f2b7852 into xline-kv:master Jul 16, 2024
16 checks passed
@mergify mergify bot requested a review from a team July 16, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants