Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: xline command execution #808

Merged

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented May 9, 2024

Depends-On: #687 #807 #673 #853

This PR refactors xline kv storage and xline command executor.

Some tests will not be fixed in this PR; they will be fixed in #821.

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds force-pushed the xline-command-execution branch from 84a437a to 52b4640 Compare May 9, 2024 09:47
Copy link

mergify bot commented May 9, 2024

@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml.

@bsbds bsbds force-pushed the xline-command-execution branch 2 times, most recently from 031671c to 40439ad Compare May 16, 2024 06:49
Copy link

mergify bot commented May 16, 2024

@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml.

@bsbds bsbds added this to the v0.7.0 milestone May 27, 2024
@bsbds bsbds force-pushed the xline-command-execution branch 4 times, most recently from c90a838 to 94e9256 Compare June 17, 2024 01:33
@bsbds bsbds mentioned this pull request Jun 17, 2024
@bsbds bsbds force-pushed the xline-command-execution branch 3 times, most recently from 83f2f51 to e3caa90 Compare July 17, 2024 03:21
@bsbds bsbds marked this pull request as ready for review July 17, 2024 03:21
@mergify mergify bot requested a review from a team July 17, 2024 03:22
@mergify mergify bot marked this pull request as draft July 17, 2024 03:25
@mergify mergify bot added the CI:fail CI has failed label Jul 17, 2024
@bsbds bsbds removed the CI:fail CI has failed label Jul 17, 2024
@bsbds bsbds marked this pull request as ready for review July 17, 2024 03:26
@mergify mergify bot marked this pull request as draft July 17, 2024 03:26
@mergify mergify bot added the CI:fail CI has failed label Jul 17, 2024
@xline-kv xline-kv deleted a comment from mergify bot Jul 17, 2024
@xline-kv xline-kv deleted a comment from mergify bot Jul 17, 2024
@bsbds bsbds marked this pull request as ready for review July 17, 2024 03:39
@bsbds bsbds removed the CI:fail CI has failed label Jul 17, 2024
Copy link

mergify bot commented Jul 17, 2024

@bsbds Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft July 17, 2024 03:43
@mergify mergify bot added the CI:fail CI has failed label Jul 17, 2024
@bsbds bsbds marked this pull request as ready for review July 17, 2024 09:11
@bsbds bsbds removed the CI:fail CI has failed label Jul 18, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash these commits.

crates/xline/src/storage/alarm_store.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/lease_store/mod.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/kv_store.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/kv_store.rs Outdated Show resolved Hide resolved
crates/xline/src/storage/kv_store.rs Outdated Show resolved Hide resolved
crates/curp-external-api/src/cmd.rs Show resolved Hide resolved
crates/xline/src/revision_number.rs Outdated Show resolved Hide resolved
crates/xline/src/revision_number.rs Outdated Show resolved Hide resolved
crates/curp/src/server/cmd_worker/mod.rs Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 23, 2024 07:51
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash these commits.

@mergify mergify bot requested a review from a team July 25, 2024 01:38
@bsbds bsbds force-pushed the xline-command-execution branch 2 times, most recently from 52a9aa0 to 82b817f Compare July 25, 2024 01:52
Copy link

mergify bot commented Jul 25, 2024

@bsbds You've modified the workflows. Please don't forget to update the .mergify.yml.

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>

chore: add reminder of a revision issue

Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team July 25, 2024 01:55
@Phoenix500526 Phoenix500526 merged commit 9b78057 into xline-kv:refactor-v0.7.0-new Jul 25, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants