refactor: propose id #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingKa28
force-pushed
the
refactor/propose-id
branch
2 times, most recently
from
a03522a
to
144b7e3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 60.62% 59.23% -1.39%
==========================================
Files 14 14
Lines 1770 1798 +28
==========================================
- Hits 1073 1065 -8
- Misses 591 641 +50
+ Partials 106 92 -14 ☔ View full report in Codecov by Sentry. |
LingKa28
force-pushed
the
refactor/propose-id
branch
from
144b7e3
to
f682a08
Compare
LingKa28
force-pushed
the
refactor/propose-id
branch
from
f682a08
to
d5c632b
Compare
Signed-off-by: LingKa <cnfty786@gmail.com>
Signed-off-by: LingKa <cnfty786@gmail.com>
LingKa28
force-pushed
the
refactor/propose-id
branch
2 times, most recently
from
2c61152
to
23e0893
Compare
Signed-off-by: LingKa <cnfty786@gmail.com>
LingKa28
force-pushed
the
refactor/propose-id
branch
from
23e0893
to
0a71538
Compare
Phoenix500526
approved these changes
Jan 16, 2024
themanforfree
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Refact propose id due to proto definition changes.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No.