Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify simple scope settings #382

Closed
waruqi opened this issue Apr 8, 2019 · 0 comments
Closed

Simplify simple scope settings #382

waruqi opened this issue Apr 8, 2019 · 0 comments

Comments

@waruqi
Copy link
Member

waruqi commented Apr 8, 2019

option("test1")
    set_default(true)
    set_showmenu(true)
    set_description("test1 option")

option("test2")
    set_default(true)
    set_showmeu(true)

option("test3")
    set_default("hello")

For some simple scope settings, we can simplify to

option("test1", {default = true, showmenu = true, description = "test1 option"})
option("test2", {default = true, showmenu = true})
option("test3", {default = "hello"})

In addition to option, we can also simplify some target scopes.

target("demo")
    set_kind("binary")
    add_files("src/*.c")
target("demo", {kind = "binary", files = "src/*.c"})
@waruqi waruqi added this to the v2.2.6 milestone Apr 8, 2019
@waruqi waruqi changed the title Simplify tiny settings for scope() Simplify simple scope settings Apr 8, 2019
@waruqi waruqi closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant