Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/Split VerifiedCredentialV2 to be indicative of verification state #744

Open
Tracked by #693 ...
insipx opened this issue May 16, 2024 · 0 comments
Open
Tracked by #693 ...
Labels
Client App enhancement New feature or request inbox-id Support for Inbox ID

Comments

@insipx
Copy link
Contributor

insipx commented May 16, 2024

Is your feature request related to a problem?

Initial context: https://github.com/xmtp/libxmtp/pull/689/files#r1594773059

Describe the solution to the problem

VerifiedKeyPackageV2 (Key Package verification for InboxId KeyPackages) are not truly verified client-side, since client has not checked for the existence of an InboxID. The way VerifiedKeyPackageV2 exists today is still useful from the standpoint of MLS Validation Service/XmtpNodeGo.

Describe the uses cases for the feature

Split VerifiedKeyPackageV2 into ParsedKeyPackage and VerifiedKeyPackage. ParsedKeyPackage would be largely similar to VerifiedKeyPackageV2 as it is today, VerifiedKeyPackage would do the actual verification checks. ParsedKeyPackage can be made into a VerifiedKeyPackage via a TryFrom Implementation.

Additional details

No response

@insipx insipx added enhancement New feature or request inbox-id Support for Inbox ID labels May 16, 2024
@insipx insipx changed the title Feature request: Rename/Split VerifiedCredentialV2 to be indicative of verification state Rename/Split VerifiedCredentialV2 to be indicative of verification state May 16, 2024
@bwcDvorak bwcDvorak added Group Chat - Prod inbox-id Support for Inbox ID and removed inbox-id Support for Inbox ID labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client App enhancement New feature or request inbox-id Support for Inbox ID
Projects
None yet
Development

No branches or pull requests

2 participants