Fix Clickhouse Test #455
Merged
Fix Clickhouse Test #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My ultimate goal is to make a PR improving \copy support for Clickhouse but didn't want to include unrelated test fixes there. |
|
Thanks for taking a look, @nineinchnick ! |
kenshaw
added a commit
to xo/homebrew-xo
that referenced
this pull request
May 11, 2024
## What's Changed * Fix Clickhouse Test by @murfffi in xo/usql#455 * chore: fix function name in comment by @oftenoccur in xo/usql#456 * Fixes in \copy implementation for Clickhouse by @murfffi in xo/usql#457 ## New Contributors * @murfffi made their first contribution in xo/usql#455 * @oftenoccur made their first contribution in xo/usql#456 **Full Changelog**: xo/usql@v0.18.1...v0.19.0
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
May 11, 2024
## What's Changed * Fix Clickhouse Test by @murfffi in xo/usql#455 * chore: fix function name in comment by @oftenoccur in xo/usql#456 * Fixes in \copy implementation for Clickhouse by @murfffi in xo/usql#457 ## New Contributors * @murfffi made their first contribution in xo/usql#455 * @oftenoccur made their first contribution in xo/usql#456 **Full Changelog**: xo/usql@v0.18.1...v0.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues in drivers/clickhouse/clickhouse_test.go
select name from system.functions. This is the case either for 22.7 used by the test or the latest Clickhouse. Looking at Clickhouse bugs like Missing functions in system.functions ClickHouse/ClickHouse#48260 , Clickhouse rarely includes aliases in system.functions.go test ./drivers/clickhousepasses with these changes.