Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Update NewAccountService to stop creating static routes on new account. #6

Open
sappenin opened this issue Feb 5, 2020 · 4 comments

Comments

@sappenin
Copy link
Contributor

sappenin commented Feb 5, 2020

Currently, when Hermes is instructed to create a new account, it's also creating a new static-route so that the Connector routes packets to the SPSP server.

Instead, we should enable locally-fulfilled packets in the Connector, and stop creating static-routes. The changes introduced here mean that we no longer need to add a static route. Instead, we can configure the SPSP server to answer to all accounts in test.jc.spsp and as long as it has the same shared-secret as the SPSP server, things should just work.

@nkramer44
Copy link
Contributor

@sappenin did we make any changes in the SPSP server to handle this? Do we need to? Should we do this for 3/25 release?

@sappenin
Copy link
Contributor Author

sappenin commented Mar 4, 2020

Not yet - we can leave things as-is for 3/25. @nhartner to keep me honest.

@sappenin
Copy link
Contributor Author

sappenin commented May 27, 2020

It looks like Hermes is setting sendRoutes to true, even for child accounts, so we should stop doing that as well.

However, note that if sendRoutes is set to true for a local account, the actual "sending" of routes is only triggered when the peer sends us (i.e., the Connector) a route-control request. In other words, the "sending of routes" to a peer must be triggered by that peer, and local accounts will never trigger such requests -- thus, setting sendRoutes to true is benign when Hermes does it for a local account in Xpring.io.

@nhartner
Copy link
Contributor

We should also stop adding outgoing settings to custom settings of new accounts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants