Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how we access dtype #45

Closed
abkfenris opened this issue Nov 22, 2023 · 0 comments · Fixed by #46
Closed

Change how we access dtype #45

abkfenris opened this issue Nov 22, 2023 · 0 comments · Fixed by #46

Comments

@abkfenris
Copy link
Member

Currently we are accessing dtype from the da.encoding dict. We should be able to use da.dtype instead, which is less likely to be altered by various data processing steps.

xpublish-opendap/xpublish_opendap/dap_xarray.py

Line 78 in fc02c72

data=da.astype(da.encoding["dtype"]).data,

xref: xpublish-community/xpublish#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accessing dtype via .dtype attribute as opposed to encoding hash map xaviernogueira/xpublish-opendap
1 participant
@abkfenris