Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible coroutine leaks caused by closing the connection with SetDeadline #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed possible coroutine leaks caused by closing the connection with SetDeadline #251

wants to merge 1 commit into from

Conversation

blinkbean
Copy link

@blinkbean blinkbean commented Nov 6, 2023 •
edited
Loading

Resolves #250
See detailed description in the fore-mentioned issue.

@xtaci
Copy link
Owner

xtaci commented Nov 6, 2023

need description on this issue

@faddat
Copy link

faddat commented Jan 21, 2024

@xtaci I think that the issue is that we'd always return nil previously.

I'm trying to learn the codebase, and what I think that these changes do is explicitly send back a connection close.

I think that the author could be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blinkbean @xtaci @faddat