zmodem/demo is accidentally uploaded to npm package

[mgenware]

Thanks for this great project. I ran into this when integrating xterm.js to a webpack project.

Failed to compile.

./node_modules/xterm/dist/addons/zmodem/demo/app.js
Module not found: Can't resolve 'express-ws'

Seems the express-ws module is only needed in a demo project, which was accidentally uploaded to npm.

Details

• Browser and browser version:
  Node v9

• OS version:
  macOS 10.13

• xterm.js version:
  Latest (3.4.1)

Steps to reproduce

1. Install xterm.js (yarn add xterm)
2. ./node_modules/xterm/dist/addons/zmodem/demo exists

[eeeeethan2333]

I also encountered this issue!

[theflyingape]

A tangential point: express-ws has a stale dependency to an older ws that has a DoS vulnerability. Can the demo implement latest ws instead?

[Tyriar]

@theflyingape well it's just a dev dependency so i don't see that as such a bit issue, a PR to upgrade the dep is welcome though provided it's well tested.

[Tyriar]

This issue is already fixed, update to xterm@3.4.0:

❯ ls ./node_modules/xterm/src/addons/zmodem
package.json    tsconfig.json   zmodem.ts

❯ ls ./node_modules/xterm/lib/addons/zmodem
package.json    zmodem.d.ts     zmodem.js.map
tsconfig.json   zmodem.js

[Tyriar]

Actually it's not, src and lib are fine but dist is still a problem.

[Tyriar]

This is fixed, I removed the zmodem demo recently. Also the addon will be removed as part of #1128, we're hoping a community member who needs this will pick it up and maintain a new addon.