Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make extended cell attributes extendable #3489

Closed
jerch opened this issue Sep 28, 2021 · 3 comments
Closed

make extended cell attributes extendable #3489

jerch opened this issue Sep 28, 2021 · 3 comments
Assignees
Labels
area/parser type/enhancement Features or improvements to existing features

Comments

@jerch
Copy link
Member

jerch commented Sep 28, 2021

Coming from #2503. Also related #2904.

Extended attributes on cells offer a simply way of extending terminal buffer functionality for other purposes. Currently it is not possible to extend them in a flexible way to be used for custom data from addons.

TODO: Come up with an easy to interface to extend extended attributes from addons. Bonus goal - make this type safe even for runtime extensions (hard one with TS' static type system).

@jerch jerch added type/enhancement Features or improvements to existing features area/parser labels Sep 28, 2021
@jerch jerch self-assigned this Sep 28, 2021
This was referenced Sep 28, 2021
@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2021

Related: #2919

@jerch
Copy link
Member Author

jerch commented Oct 20, 2021

@Tyriar Yeah the CellMarker idea is somewhat related. But I am not sure, whether to go that path at all - in the image addon I cancelled that idea and went with a viewport scan, which turned out to be fast enough for that purpose. CellMarker would certainly speedup those tasks, but would penalize the buffer logic at other ends.

@jerch
Copy link
Member Author

jerch commented Dec 8, 2021

Somewhat obsolete, thus closing.

@jerch jerch closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/parser type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants