Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incomplete search results #3794

Closed
meganrogge opened this issue May 12, 2022 · 3 comments · Fixed by #3811
Closed

incomplete search results #3794

meganrogge opened this issue May 12, 2022 · 3 comments · Fixed by #3811
Assignees
@Tyriar @meganrogge
Labels
area/addon/search type/bug Something is misbehaving
Milestone
4.19.0

Comments

@meganrogge
Copy link
Member

meganrogge commented May 12, 2022 •
edited
Loading

search.mov
@meganrogge meganrogge added area/addon/search type/bug Something is misbehaving labels May 12, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone May 12, 2022
@meganrogge
Copy link
Member Author

meganrogge commented May 12, 2022 •
edited
Loading

search results seem to get fixed by typing / changing the buffer eventually

rendered.mov

@meganrogge
Copy link
Member Author

the problem starts to happen when baseY here is 1 instead of 0 https://github.com/meganrogge/xterm.js/blob/7b4423819ee4f5d87118b40445b185af4fc573f4/addons/xterm-addon-search/src/SearchAddon.ts#L209

@meganrogge
Copy link
Member Author

meganrogge commented May 14, 2022 •
edited
Loading

this is happening because those lines in the buffer are actually "" 🤔 even when they should and appear to have content
Screen Shot 2022-05-13 at 5 11 58 PM

@meganrogge meganrogge mentioned this issue May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
area/addon/search type/bug Something is misbehaving
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

update search results onBufferContentsChange meganrogge/xterm.js
2 participants
@Tyriar @meganrogge