Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using registerLinkProvider requires setting allowProposedApi #4203

Closed
Nokel81 opened this issue Oct 14, 2022 · 0 comments · Fixed by #4204
Closed

Using registerLinkProvider requires setting allowProposedApi #4203

Nokel81 opened this issue Oct 14, 2022 · 0 comments · Fixed by #4204
Milestone
5.1.0

Comments

@Nokel81
Copy link
Contributor

Nokel81 commented Oct 14, 2022

Details

  • Browser and browser version: N/A
  • OS version: macOS 12.4
  • xterm.js version: 5.0.0

Steps to reproduce

  1. Run const xterm = new Terminal({ ... }); without specifying allowProposedApi: true
  2. Call xterm.registerLinkProvider()

In version 5 the documentation changed implying that it is no longer experimental, but the check is still present in the source code.
@silamon silamon mentioned this issue Oct 15, 2022
Merged
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Remove check proposed api checks silamon/xterm.js
2 participants
@Tyriar @Nokel81