Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overline in DOM renderer doesn't show depending on the font #4541

Open
Tyriar opened this issue May 31, 2023 · 1 comment
Open

Overline in DOM renderer doesn't show depending on the font #4541

Tyriar opened this issue May 31, 2023 · 1 comment
Labels
area/renderer-dom type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2023

Current vertical-align: top

Screenshot 2023-05-31 at 6 55 25 am

It works with vertical-align: middle, maybe that's the workaround? I wouldn't be surprised if it hid the underlines in this case though

Screenshot 2023-05-31 at 6 56 26 am
@jerch
Copy link
Member

jerch commented Jul 31, 2023

I also stumbled over this in the faster renderer PR, the problem is basically rounding issues in the dimension calc, which leads to edge cases, where the row is simply not high enough to show all decorations done by the browser.

This would also get fixed by an inline rework, which I did not deal with yet in the PR (postponed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants