Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Could not release an element not yet acquired #919

Closed
parisk opened this issue Aug 25, 2017 · 2 comments
Closed

Error: Could not release an element not yet acquired #919

parisk opened this issue Aug 25, 2017 · 2 comments
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@parisk
Copy link
Contributor

parisk commented Aug 25, 2017

Seems like we ran into this error in production in SourceLair and looks like it's breaking refresh.

@Tyriar do you have any idea if we can handle this in the object reusing pool or what would be a good practice of handling it downstream?

https://github.com/sourcelair/xterm.js/blob/7645bdd418b37a8bd176a69179c06178c8cb1130/src/utils/DomElementObjectPool.ts#L49-L51


Details

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

The whole performance benefit of this comes from precisely calling acquire and release the correct number of times.

I notice there's probably a leak here as we're not releasing the elements. That's not this problem though.

https://github.com/sourcelair/xterm.js/blob/bfdc468d4bc823b242ada286c7e8ecc7978f2b72/src/Terminal.ts#L1942

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

It's hard to say if this is fixed in v3 or not. It could also have something to do sourcelair? I can't see any in our error reporting.

@parisk parisk mentioned this issue Sep 4, 2017
22 tasks
@Tyriar Tyriar self-assigned this Sep 4, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants