Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features to demo #939

Closed
Tyriar opened this issue Sep 4, 2017 · 3 comments
Closed

Add new features to demo #939

Tyriar opened this issue Sep 4, 2017 · 3 comments
Labels
help wanted type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 4, 2017

We should add new features to the demo:

  • fontSize
  • fontFamily
  • lineHeight
  • themes
@Tyriar Tyriar mentioned this issue Sep 4, 2017
22 tasks
@theflyingape
Copy link
Contributor

FWIIW, I am finding that the client WebSocket does not receive an onclose() event. The demo/app.js might need this event listener added in its app.ws():

  term.on('close', function() {
    ws.close();
  });

@Tyriar
Copy link
Member Author

Tyriar commented Nov 11, 2017

@theflyingape do you know if this would fix any bugs in the demo? Or is this just a general clean up thing?

@theflyingape
Copy link
Contributor

Cleanup mainly. If you type exit in the shell it presents, the running backend app.js does not handle the PID closing, which in turn does not pass on the ws.on('close') event for its cleanup: echoing a 'Closed terminal ' + pid status. And a netstat confirms that the WebSocket remains ESTABLISHED between client/server without it.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Jun 3, 2018
@Tyriar Tyriar added this to the 3.5.0 milestone Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

2 participants