From 6acf6d9bdce3ad6b00e8b6a0a6b9aeca1d71a606 Mon Sep 17 00:00:00 2001 From: Nikolaos Papaspyrou Date: Thu, 24 Feb 2022 19:19:35 +0100 Subject: [PATCH] test: update V8 trace events test expectations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The event "V8.GCScavenger" is soon to be deprecated. Most of V8 trace events are either behind flags and disabled by default, or are emitted infrequently. Instead of replacing "V8.GCScavenger" with some other random event, this patch updates the tests to check that there is some event in the category "v8" whose name starts with "V8.". PR-URL: https://github.com/nodejs/node/pull/42120 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Mestery Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig --- test/parallel/test-trace-events-all.js | 2 +- test/parallel/test-trace-events-v8.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-trace-events-all.js b/test/parallel/test-trace-events-all.js index b9f9b70a61b81b..8e836561ff7091 100644 --- a/test/parallel/test-trace-events-all.js +++ b/test/parallel/test-trace-events-all.js @@ -27,7 +27,7 @@ proc.once('exit', common.mustCall(() => { return false; if (trace.cat !== 'v8') return false; - if (trace.name !== 'V8.GCScavenger') + if (!trace.name.startsWith('V8.')) return false; return true; })); diff --git a/test/parallel/test-trace-events-v8.js b/test/parallel/test-trace-events-v8.js index 5d06124d6879b5..e5fc8b6c726600 100644 --- a/test/parallel/test-trace-events-v8.js +++ b/test/parallel/test-trace-events-v8.js @@ -29,7 +29,7 @@ proc.once('exit', common.mustCall(() => { return false; if (trace.cat !== 'v8') return false; - if (trace.name !== 'V8.GCScavenger') + if (!trace.name.startsWith('V8.')) return false; return true; }));