Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't modify cell content issue #1264

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix can't modify cell content issue #1264

merged 1 commit into from
Jun 30, 2022

Conversation

xdlrt
Copy link
Contributor

@xdlrt xdlrt commented Jun 30, 2022

PR Details

Description

Related Issue

#1263

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #1264 (c9c7270) into master (eee6607) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          31       31           
  Lines       23260    23266    +6     
=======================================
+ Hits        22902    22908    +6     
  Misses        239      239           
  Partials      119      119           
Flag Coverage Δ
unittests 98.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cell.go 97.50% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee6607...c9c7270. Read the comment docs.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2022
@xuri xuri changed the title WIP: fix can't modify cell content issue Fix can't modify cell content issue Jun 30, 2022
@xuri xuri merged commit 18afc88 into qax-os:master Jun 30, 2022
@xuri
Copy link
Member

xuri commented Jun 30, 2022

LGTM, thanks for your great work.

xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
…cases

Remove inline rich text when setting cell value and cell formulas
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
…cases

Remove inline rich text when setting cell value and cell formulas
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
…cases

Remove inline rich text when setting cell value and cell formulas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants