Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Factor connector #1386

Closed
dd32 opened this issue Dec 8, 2022 · 3 comments · Fixed by #1567
Closed

Add Two Factor connector #1386

dd32 opened this issue Dec 8, 2022 · 3 comments · Fixed by #1567
Labels
enhancement integration Integration with other plugins or WordPress core functionality
Milestone

Comments

@dd32
Copy link
Contributor

dd32 commented Dec 8, 2022

Feature Request

The WordPress.org plugin "Two Factor" is used by 50k+ installs, having the actions from that plugin available in Stream would be beneficial to Stream users.

This is an ideal 2FA plugin to add to stream, as it's vendor neutral, not developed by any single company, and will add the appropriate actions/terms for other 2FA plugins to integrate with Stream in a consistent manner.

@dd32
Copy link
Contributor Author

dd32 commented Jul 25, 2024

Just noting that I've started some work on this as a custom connector on WordPress.org: https://github.com/WordPress/wporg-mu-plugins/blob/trunk/mu-plugins/plugin-tweaks/stream/class-connector-two-factor.php via WordPress/wporg-mu-plugins#643

@tharsheblows tharsheblows added this to the 4.1.0 milestone Jul 31, 2024
@tharsheblows
Copy link
Contributor

@dd32 Thank you! I'm using that when adding the connector to Stream. 😊

I'm changing the connector name to "twofactor" so you can pre-emptively remove the Stream connector and use your own more easily.

I'm also removing the actions from the WebAuthn Provider plugin... I think this is the right thing to do at this moment in time but if you disagree, please tell me!

@dd32
Copy link
Contributor Author

dd32 commented Aug 21, 2024

@tharsheblows That's perfectly fine! WebAuthN will land in the two-factor plugin at some point, unsure if it'll be from that plugin or even follow the same methods/naming.

Thanks for looking into this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement integration Integration with other plugins or WordPress core functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants