Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export stops at 10,000 items #1476

Closed
cbirdsong opened this issue Apr 2, 2024 · 3 comments · Fixed by #1558
Closed

Export stops at 10,000 items #1476

cbirdsong opened this issue Apr 2, 2024 · 3 comments · Fixed by #1558
Labels
bug support forum From the WP.org plugin support forum
Milestone

Comments

@cbirdsong
Copy link

cbirdsong commented Apr 2, 2024

Bug Report

Expected Behavior

A CSV export should contain all the data Stream has.

Actual Behavior

The export is cut off at 10,000 items.

Steps to Reproduce the Problem

  1. Set a high-traffic site to retain data for enough time to log more than 10,000 items.
  2. Wait until there are more than 10,000 items.
  3. Export to CSV or JSON
  4. Open the exported file. You should find only 10,000 rows or items.

I have only seen this on one site

System Information

  • Stream plugin version: 4.0.0
  • WordPress version: 6.4.3
  • PHP version: 7.4
  • Browser: Firefox
  • Computer operating system: Mac OS

This would be largely sidestepped by fixing #1191

@cbirdsong cbirdsong changed the title CSV export stops at 10,000 items Export stops at 10,000 items Apr 2, 2024
@cbirdsong
Copy link
Author

cbirdsong commented Apr 2, 2024

It looks like this should be an easy fix. From class-export.php:

/**
* Increase pagination limit for CSV Output
*
* @param int $records_per_page Old limit for records_per_page.
* @return int
*/
public function disable_paginate( $records_per_page ) {
    return 10000;
}

I have no idea what a sensible number to cap it at would be, though. The site I discovered this on has 164,000 records and counting and Stream otherwise works fine with that volume, so probably higher than that?

@lkraav
Copy link
Contributor

lkraav commented Apr 3, 2024

I have no idea what a sensible number to cap it at would be, though. The site I discovered this on has 164,000 records and counting and Stream otherwise works fine with that volume, so probably higher than that?

apply_filters() makes sense here, so everybody can have it according to their environment capability.

@tharsheblows tharsheblows added bug support forum From the WP.org plugin support forum labels Jul 16, 2024
@tharsheblows
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug support forum From the WP.org plugin support forum
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants