FreeBSD: ACPI thermal device not found error

[Neved4]

Summary

temp: no device hw.acpi.thermal.tz0.temperature found error on startup.

ACPI system related parameters can be unreliable and depend heavily on hardware vendor implementations.

Proposal: silently tolerate missing acpi_thermal data if temperature module for builtin cpu sensor (e.g. coretemp, amdtemp) is loaded and available.

System details

• System: FreeBSD 12.2-RELEASE
• CPU: AMD Ryzen 9 3900X
• Terminal: /dev/pts/10
• Version: gotop-4.0.1

Steps to reproduce

$ gotop -V
2020/11/14 17:33:08 temp: no device hw.acpi.thermal.tz0.temperature found
2020/11/14 17:33:08 temp: no device hw.acpi.thermal.tz0.temperature found
2020/11/14 17:33:09 temp: no device hw.acpi.thermal.tz0.temperature found

Relevant logs

The ~/.cache/gotop/ logs are empty.

---

Notes

1. The system monitoring tool glances was also tested: it does not seem to throw this error on startup.

[xxxserxxx]

Related to #130, I believe.

[Zeezee1210]

Is this not just a log line for missing hw.acpi.thermal.tz0.temperature ? Doesn't fail though?
If there is coretemp or amdtemp installed then the dev.cpu.0.temperature should be available and it registers that device.

These are the 2 entries looked for::
var sensorOIDS = map[string]string{ "dev.cpu.0.temperature": "CPU 0 ", "hw.acpi.thermal.tz0.temperature": "Thermal zone 0", }

And this is when it's processed and produces the log line mentioned:
for k, _ := range sensorOIDS { idx := strings.Index(string(bs), k) if idx < 0 { log.Printf("temp: no device %s found", k) } else { rv = append(rv, k) } } return rv

Looping though the OIDs it could miss the acpi entry, print the log line but then continue with the other OID.
Should only fail completely if both of those OIDs are missing.

If you want to remove the logging for this you could change to:
for k, _ := range sensorOIDS { idx := strings.Index(string(bs), k) if idx > -1 { rv = append(rv, k) } } return rv

[xxxserxxx]

Ok. I don't see any reason why not to do it as suggested; it seems Caleb was trying to cover bases, not that we expect all devices to be available on FreeBSD.