You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The TryCatchRetry.RunWithDelayAsync(..) methods seem to work incorrectly because of the first argument - being Task or IAsyncOperation.
This line await task;
doesn't actually re-run the task. It will always return the faulted task, so that whole purpose of the TryCatchRetry logic is lost.
Instead of receiving a Task argument, we should take a Func<Task> as the first argument.
Am I getting it wrong?
The text was updated successfully, but these errors were encountered:
You're most likely correct. Bonus points for a pull request and extra points for a unit test! :)
Sorry if I caused you trouble by adding untested code to the toolkit!
The
TryCatchRetry.RunWithDelayAsync(..)
methods seem to work incorrectly because of the first argument - being Task or IAsyncOperation.This line
await task;
doesn't actually re-run the task. It will always return the faulted task, so that whole purpose of the TryCatchRetry logic is lost.
Instead of receiving a
Task
argument, we should take aFunc<Task>
as the first argument.Am I getting it wrong?
The text was updated successfully, but these errors were encountered: