Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prometheus-client-0.10.0 #6

Closed
alexander37137 opened this issue Aug 16, 2019 · 3 comments
Closed

Support prometheus-client-0.10.0 #6

alexander37137 opened this issue Aug 16, 2019 · 3 comments
Assignees
@Envek

Comments

@alexander37137
Copy link
Contributor

alexander37137 commented Aug 16, 2019 •
edited
Loading

In prometheus-client version 0.10.0 fixed support of pre-fork servers
prometheus/client_ruby#9 (comment)
But yabeda-prometheus failed to start with this version with such exception

web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/prometheus-client-0.10.0.pre.alpha.2/lib/prometheus/client/label_set_validator.rb:18:in `initialize'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/metric_wrapper.rb:12:in `new'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/metric_wrapper.rb:12:in `initialize'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/adapter.rb:17:in `new'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/adapter.rb:17:in `register_counter!'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/base_adapter.rb:8:in `register!'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `block in register_metric'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `each_value'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `register_metric'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:41:in `counter'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:21:in `block in <module:Sidekiq>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:17:in `class_exec'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:17:in `configure'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:18:in `<module:Sidekiq>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:12:in `<module:Yabeda>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:11:in `<main>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:95:in `rescue in block in require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:72:in `block in require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:65:in `each'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:65:in `require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/lib/ruby/2.6.0/bundler.rb:114:in `require'
web_1        | 13:20:20 sidekiq-1.1 | /rest/u/apps/elections_admin/current/config/application.rb:18:in `<top (required)>'
web_1        | 13:20:20 sidekiq-1.1 | /rest/u/apps/elections_admin/current/config/environment.rb:2:in `require_relative'
web_1        | 13:20:20 sidekiq-1.1 | /rest/u/apps/elections_admin/current/config/environment.rb:2:in `<top (required)>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:288:in `require'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:288:in `boot_system'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:46:in `run'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/gems/sidekiq-5.2.7/bin/sidekiq:12:in `<top (required)>'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/bin/sidekiq:23:in `load'
web_1        | 13:20:20 sidekiq-1.1 | /usr/local/bundle/bin/sidekiq:23:in `<main>'
web_1        | 13:20:20 sidekiq-1.1 | 2019-08-16T13:20:20.523Z 13 TID-goc7qexxt INFO: Booting Sidekiq 5.2.7 with redis options {:id=>"Sidekiq-server-PID-13", :url=>nil}
web_1        | 13:20:21 sidekiq-2.1 | missing keyword: expected_labels
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/prometheus-client-0.10.0.pre.alpha.2/lib/prometheus/client/label_set_validator.rb:18:in `initialize'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/metric_wrapper.rb:12:in `new'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/metric_wrapper.rb:12:in `initialize'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/adapter.rb:17:in `new'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-prometheus-0.1.4/lib/yabeda/prometheus/adapter.rb:17:in `register_counter!'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/base_adapter.rb:8:in `register!'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `block in register_metric'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `each_value'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:62:in `register_metric'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:41:in `counter'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:21:in `block in <module:Sidekiq>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:17:in `class_exec'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-0.1.3/lib/yabeda/dsl/class_methods.rb:17:in `configure'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:18:in `<module:Sidekiq>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:12:in `<module:Yabeda>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/yabeda-sidekiq-0.1.3/lib/yabeda/sidekiq.rb:11:in `<main>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:95:in `rescue in block in require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:72:in `block in require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:65:in `each'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/lib/ruby/2.6.0/bundler/runtime.rb:65:in `require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/lib/ruby/2.6.0/bundler.rb:114:in `require'
web_1        | 13:20:21 sidekiq-2.1 | /rest/u/apps/elections_admin/current/config/application.rb:18:in `<top (required)>'
web_1        | 13:20:21 sidekiq-2.1 | /rest/u/apps/elections_admin/current/config/environment.rb:2:in `require_relative'
web_1        | 13:20:21 sidekiq-2.1 | /rest/u/apps/elections_admin/current/config/environment.rb:2:in `<top (required)>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:288:in `require'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:288:in `boot_system'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/sidekiq-5.2.7/lib/sidekiq/cli.rb:46:in `run'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/gems/sidekiq-5.2.7/bin/sidekiq:12:in `<top (required)>'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/bin/sidekiq:23:in `load'
web_1        | 13:20:21 sidekiq-2.1 | /usr/local/bundle/bin/sidekiq:23:in `<main>'
@Envek Envek self-assigned this Aug 27, 2019
@Envek
Copy link
Member

Envek commented Aug 27, 2019

Sorry for the late reply – I will take a look in a couple of days

@Envek
Copy link
Member

Envek commented Oct 15, 2019 •
edited
Loading

The problem here is that they changed API in 0.10 (see their UPGRADING file), so now I have to break compatibility with prometheus-client-mmap (anyway now it should be redundant, because now official client implemented the same). Stay tuned.

@Envek
Copy link
Member

Envek commented Jan 14, 2020

Support for prometheus-client 1.0 (they have bumped version from 0.10 to 1.0) was released in 0.2.0. Enjoy!

@Envek Envek closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Envek Envek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Envek @alexander37137