Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more metrics such as cache hit/miss #15

Open
shouichi opened this issue Oct 2, 2020 · 1 comment
Open

Adding more metrics such as cache hit/miss #15

shouichi opened this issue Oct 2, 2020 · 1 comment

Comments

@shouichi
Copy link

shouichi commented Oct 2, 2020

Hi,

ActiveSupport publishes bunch of events and we want to instrument cache hit/miss through cache_read.active_support.

https://guides.rubyonrails.org/active_support_instrumentation.html

General question: we ultimately can instrument all events published by active support but maybe it's too much. Where should we draw a line?

Thank you.

@Envek
Copy link
Member

Envek commented Oct 2, 2020

I don't think that it would be useful to subscribe to all possible things from ActiveSupport.

But for things that would be useful to many users pull requests are definitely welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants