Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just Click to select? #3

Closed
gilbox opened this issue Aug 15, 2012 · 5 comments
Closed

Just Click to select? #3

gilbox opened this issue Aug 15, 2012 · 5 comments
Assignees
Milestone

Comments

@gilbox
Copy link

gilbox commented Aug 15, 2012

I want to allow the user to just click to select an item, without having to drag it. And, if possible, click to deselect as well. Is this possible without modifying the code too much?

@yanickrochon
Copy link
Owner

I just tried a quick fix for your requested feature, unfortunately it is not as simple as it looks. Since there are (can be) animations and the selection is based on elements in the selected/available lists to be placed, if a user would do some fast clicks in a list or another will cause some element states discrepancy (some elements will not appear and/or will lose their draggable settings).

The widget is implemented to render as fast as possible and work out of a single list (sorted once) of elements. If someone can do a PR I'll be glad to review it and merge. Or you can wait until I clear my schedule some more so I can figure out a way to cleanly add a click-to-select behavior on the lists (eventually adding navigation too in some future...)

In any case, thank you for spotting this... issue.

Cheers!

@gilbox
Copy link
Author

gilbox commented Aug 16, 2012

Thanks for the reply. This list is great because scrolling, filtering, and select-all all worked incredibly fast with 5000 items in the list. The animations and drag-n-drop behavior are nice additions but not essential. I'm surprised you added dragging before clicking, but excellent work in any case!

@yanickrochon
Copy link
Owner

Forgot to mention it in the last push, but see the feature-click-select branch.

@yanickrochon
Copy link
Owner

I think I fixed the problem just now! I had to revert some commits as my commit tree was corrupted, but I'm now back in sync with the github repository! And you may check the feature-click-select branch. If it is stable enough, it will be merged with master.

@ghost ghost assigned yanickrochon Dec 31, 2012
@yanickrochon
Copy link
Owner

This has now been implemented and stable enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants