[Fix] prop-types/component detection: avoid a crash when a local `c…

…reateElement` identifier exists Fixes #2733.
jsx-eslint · Jul 29, 2020 · 8466625 · 8466625
1 parent 530b0e8
commit 8466625
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -345,7 +345,9 @@ function componentRule(rule, context) {
 
             // check proper require.
             if (
-              requireExpression.callee.name === 'require'
+              requireExpression
+              && requireExpression.callee
+              && requireExpression.callee.name === 'require'
               && requireExpression.arguments[0]
               && requireExpression.arguments[0].value === pragma.toLocaleLowerCase()
             ) {

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2574,6 +2574,28 @@ ruleTester.run('prop-types', rule, {
       code: `
       export default function() {}
       `
+    },
+    {
+      code: `
+        import * as React from 'react';
+
+        interface Props {
+          text: string;
+        }
+
+        export const Test: React.FC<Props> = (props: Props) => {
+          const createElement = (text: string) => {
+            return (
+              <div>
+                {text}
+              </div>
+            );
+          };
+
+          return <>{createElement(props.text)}</>;
+        };
+      `,
+      parser: parsers.TYPESCRIPT_ESLINT
     }
   ],