[Fix] no-find-dom-node: Improve error message

jsx-eslint · Aug 4, 2020 · 9abc71d · 9abc71d
1 parent 5a00096
commit 9abc71d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/rules/no-find-dom-node.js b/lib/rules/no-find-dom-node.js
@@ -40,7 +40,7 @@ module.exports = {
 
         context.report({
           node: callee,
-          message: 'Do not use findDOMNode'
+          message: 'Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode'
         });
       }
     };

diff --git a/tests/lib/rules/no-find-dom-node.js b/tests/lib/rules/no-find-dom-node.js
@@ -76,7 +76,7 @@ ruleTester.run('no-find-dom-node', rule, {
       });
     `,
     errors: [{
-      message: 'Do not use findDOMNode'
+      message: 'Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode'
     }]
   }, {
     code: `
@@ -90,7 +90,7 @@ ruleTester.run('no-find-dom-node', rule, {
       });
     `,
     errors: [{
-      message: 'Do not use findDOMNode'
+      message: 'Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode'
     }]
   }, {
     code: `
@@ -104,7 +104,7 @@ ruleTester.run('no-find-dom-node', rule, {
       };
     `,
     errors: [{
-      message: 'Do not use findDOMNode'
+      message: 'Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode'
     }]
   }, {
     code: `
@@ -118,7 +118,7 @@ ruleTester.run('no-find-dom-node', rule, {
       };
     `,
     errors: [{
-      message: 'Do not use findDOMNode'
+      message: 'Do not use findDOMNode. It doesn’t work with function components and is deprecated in StrictMode. See https://reactjs.org/docs/react-dom.html#finddomnode'
     }]
   }]
 });