[Fix] jsx-curly-brace-presence: fix multiline comment case

Fixes #2716.
jsx-eslint · Aug 12, 2020 · bac0ec3 · bac0ec3
1 parent a77c0d1
commit bac0ec3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -92,6 +92,10 @@ module.exports = {
       return /['"]/.test(value);
     }
 
+    function containsMultilineComment(value) {
+      return /\/\*/.test(value);
+    }
+
     function escapeDoubleQuotes(rawStringValue) {
       return rawStringValue.replace(/\\"/g, '"').replace(/"/g, '\\"');
     }
@@ -238,6 +242,7 @@ module.exports = {
             (JSXExpressionNode.parent.type === 'JSXAttribute' && !isWhiteSpaceLiteral(expression))
             || !isLiteralWithTrailingWhiteSpaces(expression)
           )
+          && !containsMultilineComment(expression.value)
           && !needToEscapeCharacterForJSX(expression.raw, JSXExpressionNode) && (
           jsxUtil.isJSX(JSXExpressionNode.parent)
           || !containsQuoteCharacters(expression.value)

diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js
@@ -407,6 +407,16 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
         };
       `,
       options: [{props: 'never', children: 'never'}]
+    },
+    {
+      code: `
+        import React from "react";
+
+        const Component = () => {
+          return <span>{"/*"}</span>;
+        };
+      `,
+      options: [{props: 'never', children: 'never'}]
     }
   ],