Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-comment-textnodes false positive on URL #664

Closed
ljharb opened this issue Jul 6, 2016 · 0 comments
Closed

no-comment-textnodes false positive on URL #664

ljharb opened this issue Jul 6, 2016 · 0 comments
Labels
bug

Comments

@ljharb
Copy link
Member

ljharb commented Jul 6, 2016

I have JSX like the following:

<strong>
  &nbsp;https://www.example.com/attachment/download/1
</strong>

Since the line doesn't start with // or /*, there shouldn't be any way this is identified as an accidental leaked comment.
@ljharb ljharb added the bug label Jul 6, 2016
@ljharb ljharb mentioned this issue Jul 6, 2016
Closed
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 6, 2016
@petersendidit
Fix no-comment-textnodes incorrectly catching urls (fixes jsx-eslint#664
e5c6fea 
)
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 6, 2016
@petersendidit
Fix no-comment-textnodes incorrectly catching urls (fixes jsx-eslint#664
9b37d2d 
)
@petersendidit petersendidit mentioned this issue Jul 6, 2016
Merged
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 6, 2016
@petersendidit
Fix no-comment-textnodes incorrectly catching urls (fixes jsx-eslint#664
3354ca3 
)
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 6, 2016
@petersendidit
Fix no-comment-textnodes incorrectly catching urls (fixes jsx-eslint#664
554eceb 
)
yannickcr pushed a commit that referenced this issue Jul 8, 2016
@petersendidit @yannickcr
Fix no-comment-textnodes incorrectly catching urls (fixes #664)
f998882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljharb