Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsx-no-comment-textnodes to recommended configuration #751

Closed
lencioni opened this issue Aug 7, 2016 · 1 comment
Closed

Add jsx-no-comment-textnodes to recommended configuration #751

lencioni opened this issue Aug 7, 2016 · 1 comment
Assignees
Milestone

Comments

@lencioni
Copy link
Collaborator

lencioni commented Aug 7, 2016

This rule prevents comments from being accidentally injected as text nodes in JSX. This seems like a nice protection to have on and unlikely that it would catch very many legitimate uses, so I think it should be added to the recommended configuration.

I'm adding this to the 7.0.0 milestone so we don't forget to do this for our next major version bump.

@lencioni lencioni added this to the 7.0.0 milestone Aug 7, 2016
@ljharb
Copy link
Member

ljharb commented Aug 8, 2016

SGTM

@lencioni lencioni changed the title Add jsx-no-comment-textnodes Add jsx-no-comment-textnodes to recommended configuration Aug 23, 2016
@ljharb ljharb self-assigned this Apr 23, 2017
@ljharb ljharb closed this as completed in c6c5e3b Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants