From d5304a692f374b0063fdd4ecc6d62205c43d3260 Mon Sep 17 00:00:00 2001 From: Yizhi Liu Date: Mon, 28 Dec 2015 14:23:24 +0800 Subject: [PATCH 1/2] Adam bug fix --- .../core/src/main/scala/ml/dmlc/mxnet/optimizer/Adam.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scala-package/core/src/main/scala/ml/dmlc/mxnet/optimizer/Adam.scala b/scala-package/core/src/main/scala/ml/dmlc/mxnet/optimizer/Adam.scala index 7907c2059ae2..6b44b0804955 100644 --- a/scala-package/core/src/main/scala/ml/dmlc/mxnet/optimizer/Adam.scala +++ b/scala-package/core/src/main/scala/ml/dmlc/mxnet/optimizer/Adam.scala @@ -52,7 +52,7 @@ class Adam(var learningRate: Float = 0.002f, val beta1: Float = 0.9f, val beta2: this.learningRate }) * lrScale.getOrElse(index, 1f) - var (mean, variance) = state.asInstanceOf[(NDArray, NDArray)] + val (mean, variance) = state.asInstanceOf[(NDArray, NDArray)] // increment time only when the first parameters is called if (timeFirstIndex == None) { @@ -81,8 +81,8 @@ class Adam(var learningRate: Float = 0.002f, val beta1: Float = 0.9f, val beta2: } weight += -step - mean = meanT - variance = varianceT + mean.set(meanT) + variance.set(varianceT) } // Create additional optimizer state: mean, variance From d9202e3bf87189aef490dbc696268468f807d585 Mon Sep 17 00:00:00 2001 From: Yizhi Liu Date: Mon, 28 Dec 2015 14:33:20 +0800 Subject: [PATCH 2/2] clean up gitignore --- .gitignore | 33 +++++---------------------------- 1 file changed, 5 insertions(+), 28 deletions(-) diff --git a/.gitignore b/.gitignore index 3f31d7ba7f49..cd24d897adf0 100644 --- a/.gitignore +++ b/.gitignore @@ -87,37 +87,14 @@ example/notebooks/.ipynb_checkpoints/* # Scala package -# Jetbrain -mxnet-scala/.idea - -# ctags -mxnet-scala/tags - -mxnet-scala/*.class -mxnet-scala/*.log - -# sbt specific -mxnet-scala/.cache -mxnet-scala/.lib/ -mxnet-scala/dist/* -mxnet-scala/target/ -mxnet-scala/lib_managed/ -mxnet-scala/src_managed/ -mxnet-scala/project/boot/ -mxnet-scala/project/plugins/project/ - -#scala target folders +*.idea +*.class scala-package/*/target/ scala-package/*/*/target/ - -# IDE specific *.scala_dependencies *.worksheet *.idea *.iml -#eclipse -.classpath -.project -.settings - - +*.classpath +*.project +*.settings