Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should there be a 'for' attribute? #33

Closed
sheriffderek opened this issue Mar 29, 2016 · 4 comments
Closed

Should there be a 'for' attribute? #33

sheriffderek opened this issue Mar 29, 2016 · 4 comments

Comments

@sheriffderek
Copy link

It seems like the label should have it's for attribute generated as the input id is.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

Any thoughts on that?
@raycohen
Copy link
Contributor

even though the readme doesn't show it, we did add this in #22

@raycohen
Copy link
Contributor

you need to specify a radioId to get that behavior. that value will be used for the label's for attribute and the input's id attribute

@sheriffderek
Copy link
Author

Ah ha. Sorry for the duplicate!

@raycohen
Copy link
Contributor

No problem. I will add better documentation for that feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raycohen @sheriffderek