fix: parsing hints should apply for dot notation keys (#86)

yargs · Apr 15, 2017 · 3e47d62 · 3e47d62
1 parent f1903aa
commit 3e47d62
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -564,7 +564,7 @@ function parse (args, opts) {
 
     var key = keys[keys.length - 1]
 
-    var isTypeArray = checkAllAliases(key, flags.arrays)
+    var isTypeArray = checkAllAliases(keys.join('.'), flags.arrays)
     var isValueArray = Array.isArray(value)
     var duplicate = configuration['duplicate-arguments-array']
 

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -2056,6 +2056,17 @@ describe('yargs-parser', function () {
 
         parsed['x'].should.deep.equal(['a', 'b'])
       })
+
+      it('flattens duplicate array type, when argument uses dot notation', function () {
+        var parsed = parser('-x.foo a -x.foo b', {
+          array: ['x.foo'],
+          configuration: {
+            'flatten-duplicate-arrays': true
+          }
+        })
+
+        parsed['x'].should.deep.equal({foo: ['a', 'b']})
+      })
     })
 
     describe('duplicate-arguments-array VS flatten-duplicate-arrays', function () {