-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: boolean[] - eatArray() with boolean typed arrays and user defaults #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
force-pushed
the
issue/boolean-array
branch
2 times, most recently
from
July 13, 2019 17:11
d1cdc70
to
dfc3b32
Compare
@juergba this is looking like a reasonable start to me, looks like there's an outstanding |
juergba
force-pushed
the
issue/boolean-array
branch
from
July 14, 2019 06:20
dfc3b32
to
29542b2
Compare
juergba
force-pushed
the
issue/boolean-array
branch
2 times, most recently
from
July 25, 2019 12:17
7096618
to
2f2ff5a
Compare
juergba
changed the title
Fix: boolean[] - eatArray() with boolean typed arrays
Fix: boolean[] - eatArray() with boolean typed arrays and user defaults
Jul 25, 2019
@juergba 👋 just following up, would love to see this over the finish line. |
juergba
force-pushed
the
issue/boolean-array
branch
from
July 29, 2019 06:43
664a621
to
18da29e
Compare
@juergba thank you, this looks great. |
This was referenced Mar 6, 2021
Bump yargs-parser from 11.1.1 to 13.1.2 in /Frontend/sentwitt
mohammedbentiress/Sentiment-Analysis#9
Open
Closed
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The result is incorrect, it should be: { _: [], file: [ [true], [true] ] }
Description of Change
eatArray()
is called even for flags without arguments. This enables to set:boolean
with short syntax ('--bool --bool') which carries its implicit valuetrue
opts.default
for all type of options (exceptboolean
)[]
.eatArray()
: remove themultipleArrayFlag
logic. The "duplicate array" pattern is already handled withinsetKey()
depending on theflatten-duplicate-arrays
configuration option.setKey()
remains unchanged.