feat: when parsing stops, we now populate "--" by default #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
approved these changes
Apr 15, 2017
|
@JaKXz whoops, I forgot to drop 0.12/0.12 from AppVeyor; I figured since it's yargs 8.x, we should drop Node 0.10/0.12. |
ruimarques
reviewed
Apr 16, 2017
test/yargs-parser.js
Outdated
| '-b', '--bool', '--no-meep', '--multi=baz', | ||
| '--', '--not-a-flag', '-', '-h', '-multi', '--', 'eek' | ||
| ], { | ||
| '--': true |
There was a problem hiding this comment.
Shouldn't this be configuration: {'populate--': true} ?
There was a problem hiding this comment.
whoops, I should actually just remove this configuration; since it defaults to true now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rather than placing arguments in "_", when parsing is stopped via "--"; we now populate an array called "--" by default.
I've changed the configuration option to be named
populate--rather than--; as this better fits with the naming conventions of our other configuration settings.CC: @ruimarques