Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable emojis if terminal isn't a TTY #405

Closed
sebmck opened this issue Sep 21, 2016 · 15 comments
Closed

Disable emojis if terminal isn't a TTY #405

sebmck opened this issue Sep 21, 2016 · 15 comments
Assignees

Comments

@sebmck
Copy link
Contributor

sebmck commented Sep 21, 2016

No fun allowed.

@wycats
Copy link
Member

wycats commented Sep 21, 2016

We should likely disable them on Windows as well. yarn install is pretty jank on Windows in general for various reasons.

@jdalton
Copy link
Contributor

jdalton commented Sep 22, 2016

If TTY is the standard way to check that's cool. I'd like to avoid straight platform sniff if possible so that it will light up when emoji support is added to Windows. It would also give Windows an indicator they could use to signal support.

I think @sindresorhus has experience in this area.

@Daniel15
Copy link
Member

We should likely disable them on Windows as well.

Emoji are small and ugly in the command prompt (compared to the nice colour ones in the GUI), but they do work:
cat

Are there bugs specifically with Node.js around Emoji?

@jdalton
Copy link
Contributor

jdalton commented Sep 22, 2016

Can you provide your powershell script.

@Daniel15
Copy link
Member

It's shown in the screenshot - Literally just this:

Write-Output '🐈'

@jdalton
Copy link
Contributor

jdalton commented Sep 22, 2016

Cool, here's my output:

Here's a bit more on it sindresorhus/emoj#5.

@Daniel15
Copy link
Member

Ahh, I think I know what's up. I'm using Cmder rather than the default Windows terminal. It might use UTF-8 by default, or support Emoji while the default cmd.exe doesn't.

@jdalton
Copy link
Contributor

jdalton commented Sep 22, 2016

Here's Cmder on my system:

There's an open issue to support emojis in Cmder's dep Maximus5/ConEmu#554.

@Daniel15
Copy link
Member

I'm super confused as to how it's working in Cmder for me then! 😆

This is on my home PC, I'll try my work laptop later and see if it works there too.

sebmck pushed a commit that referenced this issue Sep 22, 2016
@sebmck sebmck closed this as completed in 9f58576 Sep 22, 2016
@sebmck sebmck self-assigned this Sep 22, 2016
@jdalton
Copy link
Contributor

jdalton commented Sep 22, 2016

@kittens Is the platform sniff 💯 needed?

@wycats
Copy link
Member

wycats commented Sep 22, 2016

@jdalton @Daniel15 I think it's certainly possible to construct some configuration on Windows where the emojis work, but it's sufficiently common in practice for them to fail on Windows that I think we should leave it off until we have a great way of reliably detecting that it'll work.

@arutkowski00
Copy link

@kittens What about Linux? I want the emoji there...

@DRSDavidSoft
Copy link
Contributor

On windows this should be definitely supported:
microsoft/terminal#190

@Daniel15
Copy link
Member

@DRSDavidSoft Based on that thread, it sounds like Windows support isn't fully complete yet.

@DRSDavidSoft
Copy link
Contributor

@Daniel15 After eight years in 2024 we can finally (I hope) say that emojis can be used with a good terminal on Windows:

image

Sidenote: In your original comment, Cmder is using ConEmu which is a great console emulator, albeit it displays emojis in that white color, still it's better than the old conhost.exe on Windows.

Of course, Windows Terminal + Cmder trumps all of them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants