Skip to content

Latest commit

 

History

History
141 lines (92 loc) · 5.95 KB

CONTRIBUTING.md

File metadata and controls

141 lines (92 loc) · 5.95 KB
Raw

Contributing to Sitecore JavaScript Services

Want to contribute to Sitecore JavaScript Services? There are a few things you need to know.

Pre-requisites:

  • node.js (Use version >= 12 or Active LTS) installed (cmd node -v to test).
  • npm (>= 6) installed (cmd npm -v to test).

Install yarn globally:

npm i -g yarn

Developing

See Branching overview below - We use dev for our current development.

  1. Fork this repository to your own GitHub account and then clone it to your local device.
  2. Create a new branch e.g. git switch -c feature/my-jss-feature
  3. When you're happy with your changes, open a Pull Request targeting the dev branch of the sitecore/jss repository. You may add the JSS Dev Reviewers group as Reviewers for potentially expedited initial PR review.
  4. Note: CI will run lint for all packages, as well as tests for all packages. Please make sure these pass or your PR can not be merged.

Setting up

In your fork from the root of the monorepo:

  • yarn install - this will install Lerna at the root, packages and will link them and allow the remaining scripts to be called.
  • (optional) yarn install-git-hooks - installs a pre-push hook that will lint all packages before a git-push. Opt out per-push with the --no-verify flag.
  • yarn build - will build all JSS packages.

In our terms workspace - it's a sample or package.

  • yarn workspaces focus <workspace> -> will install dependencies, linked dependencies for specified workspace.
  • yarn workspaces foreach -Rt --from '<workspace>' run <command> -> will run <command> script for specified workspace including linked dependencies.

Working on a package

yarn workspaces focus
yarn workspaces foreach -Rt run build

Working on a sample

yarn workspaces focus
yarn workspaces foreach -Rt --no-private run build
  • yarn reset - will clean all node_modules, re-install dependencies and link them, and then build all JSS packages.

Developing sample

For the creation of the samples we are using initializers approach.

  • initializer - the process for handling the creation of the appropriate template. See initializers.
  • template - the sample populated by ejs tokens. See templates. Templates can be:
    • base - contains foundation for the application (e.g. nextjs).
    • add-on - provides additional features for the base template. Multiple add-on templates can be applied to the base (e.g. nextjs-styleguide).

If you want to use create-sitecore-jss from your local repository, run:

cd ./packages/create-sitecore-jss
npm i -g

To start developing the sample you have to do next:

  • Copy watch.json.example file and name it watch.json. You have to set up appropriate arguments for the sample which you want to start to develop. Monorepo symlinking will work if you specify a destination under the source root samples directory (i.e. <root>\samples\<my-app>).
  • Run yarn watch. A new sample will be created in the specified destination path. You can modify any file related to your sample under src/templates folder, and changed files will be automatically copied into your sample.

Linting and Code Style guidelines

The monorepo includes a top level .eslintrc file that each package inherits. In order to avoid linting errors and adhere to our style guidelines while developing, it is strongly recommended to install the vs code extension ESLint, and use it as the document formatter. Formatting the document with this plugin will fix formatting issues and avoid linting errors.

To lint manually, the following commands are available from the root of the monorepo, you may also install the git-hook which will run these commands as a pre-push hook:

yarn lint-packages // lint everything under ./packages
yarn lint-apps // lint everything under ./samples

You may also lint a package by itself by running yarn lint while the cwd is the root of the package, for example:

cd ./packages/sitecore-jss
yarn lint

Some linting errors may be fixed automatically using the --fix flag. You may do this from the root, however you will need -- twice before the flag in order to pass the argument to the inner command

yarn lint-packages -- -- --fix

In addition to linting rules, there are a few coding guidelines worth mentioning here that will cause less friction when trying to get a PR merged.

  • TypeScript: make sure everything has the appropriate type.

  • JSDoc: new functions, interfaces, classes, etc. need to have a JSDoc style comment above their declaration. Example: https://jsdoc.app/howto-es2015-classes.html

Run unit tests

To keep everything running smoothly, please include unit tests when applicable. To run all tests, from the root of the monorepo:

yarn test-packages

In the root of a package:

yarn test

Troubleshooting

Problem: Build of package or sample fails with the following error: cannot find module ...

Solution: If dependencies in a package change, you may need to install said dependencies. From the root of the monorepo:

yarn install

yarn install will solve the problem in most cases, however in nuclear scenarios you may run the following to completely reset the monorepo:

yarn reset

Branching overview

  • master - latest released version
  • dev - latest changes for the next release
  • release branches - all major released versions